yiguolei commented on code in PR #28729:
URL: https://github.com/apache/doris/pull/28729#discussion_r1434689177
##########
be/src/vec/olap/olap_data_convertor.cpp:
##########
@@ -620,9 +620,9 @@ Status
OlapBlockDataConvertor::OlapColumnDataConvertorVarChar::convert_to_olap(
slice->size = *offset_cur - string_offset;
if (UNLIKELY(slice->size >
config::string_type_length_soft_limit_bytes &&
_check_length)) {
- return Status::NotSupported(
- "Not support string len over than "
- "`string_type_length_soft_limit_bytes` in vec
engine.");
+ return Status::Error<ErrorCode::EXCEEDED_LIMIT>(
Review Comment:
buyao dong
##########
be/src/vec/olap/olap_data_convertor.cpp:
##########
@@ -641,9 +641,9 @@ Status
OlapBlockDataConvertor::OlapColumnDataConvertorVarChar::convert_to_olap(
slice->size = *offset_cur - string_offset;
if (UNLIKELY(slice->size >
config::string_type_length_soft_limit_bytes &&
_check_length)) {
- return Status::NotSupported(
- "Not support string len over than
`string_type_length_soft_limit_bytes`"
- " in vec engine.");
+ return Status::Error<ErrorCode::EXCEEDED_LIMIT>(
+ "length of string parameter is too long[len={},
max_len={}].", slice->size,
Review Comment:
andhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
