yiguolei commented on code in PR #28419:
URL: https://github.com/apache/doris/pull/28419#discussion_r1433844950
##########
be/src/vec/exec/vsort_node.cpp:
##########
@@ -148,11 +148,13 @@ Status VSortNode::sink(RuntimeState* state,
vectorized::Block* input_block, bool
if (!new_top.is_null() && (old_top.is_null() || new_top !=
old_top)) {
auto& sort_description = _sorter->get_sort_description();
auto col =
input_block->get_by_position(sort_description[0].column_number);
- bool is_reverse = sort_description[0].direction < 0;
- auto query_ctx = state->get_query_ctx();
- RETURN_IF_ERROR(
- query_ctx->get_runtime_predicate().update(new_top,
col.name, is_reverse));
- old_top = std::move(new_top);
+ if (!col.name.empty()) {
Review Comment:
In which scenario, col.name is empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
