xiaokang commented on code in PR #28494:
URL: https://github.com/apache/doris/pull/28494#discussion_r1433730282
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -2570,5 +2573,64 @@ void
SegmentIterator::_calculate_pred_in_remaining_conjunct_root(
}
}
+bool SegmentIterator::_need_read_pk_data(ColumnId cid,
vectorized::MutableColumnPtr& column,
+ size_t nrows_read) {
+ if (_opts.tablet_schema->keys_type() != KeysType::DUP_KEYS) {
+ return false;
+ }
+
+ if (_opts.push_down_agg_type_opt != TPushAggOp::COUNT_ON_INDEX) {
+ return false;
+ }
+
+ if (!_opts.tablet_schema->column(cid).is_key()) {
Review Comment:
should be prefix of table keys
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
