github-actions[bot] commented on code in PR #28753:
URL: https://github.com/apache/doris/pull/28753#discussion_r1433626853
##########
be/src/pipeline/pipeline.h:
##########
@@ -122,14 +122,30 @@ class Pipeline : public
std::enable_shared_from_this<Pipeline> {
return _collect_query_statistics_with_every_batch;
}
- bool need_to_local_shuffle(const DataDistribution
target_data_distribution) const {
- if (target_data_distribution.distribution_type ==
ExchangeType::BUCKET_HASH_SHUFFLE ||
- target_data_distribution.distribution_type ==
ExchangeType::HASH_SHUFFLE) {
- // If `_data_distribution` of this pipeline does not match the
`target_data_distribution`,
- // we should do local shuffle.
- return target_data_distribution.operator!=(_data_distribution);
+ static bool is_hash_exchange(ExchangeType idx) {
+ return idx == ExchangeType::HASH_SHUFFLE || idx ==
ExchangeType::BUCKET_HASH_SHUFFLE;
+ }
+
+ bool need_to_local_exchange(const DataDistribution
target_data_distribution) const {
Review Comment:
warning: method 'need_to_local_exchange' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static bool need_to_local_exchange(const DataDistribution
target_data_distribution) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
