github-actions[bot] commented on code in PR #28769:
URL: https://github.com/apache/doris/pull/28769#discussion_r1433456403
##########
be/src/olap/wal_manager.cpp:
##########
@@ -335,7 +334,7 @@ Status WalManager::add_recover_wal(const std::string&
db_id, const std::string&
return Status::OK();
}
-size_t WalManager::get_wal_table_size(const std::string& table_id) {
+size_t WalManager::get_wal_table_size(int64_t table_id) {
Review Comment:
warning: method 'get_wal_table_size' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/wal_manager.h:56:
```diff
- size_t get_wal_table_size(int64_t table_id);
+ static size_t get_wal_table_size(int64_t table_id);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
