morrySnow commented on code in PR #28743: URL: https://github.com/apache/doris/pull/28743#discussion_r1432642747
########## fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java: ########## @@ -218,6 +218,7 @@ public class Rewriter extends AbstractBatchJobExecutor { // but top-down traverse can not cover this case in one iteration, so bottom-up is more // efficient because it can find the new plans and apply transform wherever it is bottomUp(RuleSet.PUSH_DOWN_FILTERS), + topDown(new ExpressionOptimization()), Review Comment: i think this is a interim solution, we need add some comment to explain why need it here. so we could do right thing when we refactor the order of rules -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org