github-actions[bot] commented on code in PR #28733: URL: https://github.com/apache/doris/pull/28733#discussion_r1432517518
########## be/src/vec/exec/scan/vmeta_scanner.cpp: ########## @@ -369,6 +372,23 @@ Status VMetaScanner::_build_workload_groups_metadata_request( return Status::OK(); } +Status VMetaScanner::_build_workload_sched_policy_metadata_request( Review Comment: warning: method '_build_workload_sched_policy_metadata_request' can be made static [readability-convert-member-functions-to-static] be/src/vec/exec/scan/vmeta_scanner.h:81: ```diff - Status _build_workload_sched_policy_metadata_request(const TMetaScanRange& meta_scan_range, + static Status _build_workload_sched_policy_metadata_request(const TMetaScanRange& meta_scan_range, ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org