github-actions[bot] commented on code in PR #28692:
URL: https://github.com/apache/doris/pull/28692#discussion_r1432304197
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -889,13 +889,21 @@ class RuntimePredicateWrapper {
return Status::OK();
}
- PrimitiveType column_type() { return _column_return_type; }
+ PrimitiveType column_type() {
+ return _column_return_type;
+ }
- bool is_bloomfilter() const { return _is_bloomfilter; }
+ bool is_bloomfilter() const {
+ return _is_bloomfilter;
+ }
- bool is_ignored_in_filter() const { return _is_ignored_in_filter; }
+ bool is_ignored_in_filter() const {
+ return _is_ignored_in_filter;
+ }
- std::string* get_ignored_in_filter_msg() const { return
_ignored_in_filter_msg; }
+ std::string* get_ignored_in_filter_msg() const {
Review Comment:
warning: method 'get_minmax_filter_desc' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status get_minmax_filter_desc(void** min_data, void** max_data) {
```
##########
be/src/pipeline/exec/nested_loop_join_build_operator.h:
##########
@@ -102,6 +102,14 @@ class NestedLoopJoinBuildSinkOperatorX final
Status sink(RuntimeState* state, vectorized::Block* in_block,
SourceState source_state) override;
+ DataDistribution get_local_exchange_type() const override {
Review Comment:
warning: method 'get_local_exchange_type' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static DataDistribution get_local_exchange_type() override {
```
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -906,7 +914,9 @@
}
}
- size_t get_in_filter_size() const { return _context.hybrid_set->size(); }
+ size_t get_in_filter_size() const {
+ return _context.hybrid_set->size();
Review Comment:
warning: method 'batch_assign' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void batch_assign(const PInFilter* filter,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
