eldenmoon commented on code in PR #27145: URL: https://github.com/apache/doris/pull/27145#discussion_r1431394418
########## be/src/vec/exec/format/json/new_json_reader.cpp: ########## @@ -1046,19 +1047,25 @@ Status NewJsonReader::_simdjson_handle_simple_json(RuntimeState* /*state*/, Bloc return Status::OK(); } - // step2: get json value by json doc - Status st = _get_json_value(&size, eof, &error, is_empty_row); - if (st.is<DATA_QUALITY_ERROR>()) { - return Status::OK(); - } - RETURN_IF_ERROR(st); - if (*is_empty_row) { - return Status::OK(); - } + for (_json_stream_iterator = _json_stream.begin(); + _json_stream_iterator != _json_stream.end(); ++_json_stream_iterator) { + if (_json_stream_iterator.current_index() >= _original_doc_size) { Review Comment: when will `if (_json_stream_iterator.current_index() >= _original_doc_size)` happened? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org