morningman commented on code in PR #28173:
URL: https://github.com/apache/doris/pull/28173#discussion_r1431026118


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ShowColumnStmt.java:
##########
@@ -98,8 +106,14 @@ public void analyze(Analyzer analyzer) throws 
AnalysisException {
             tableName.setDb(db);
         }
         tableName.analyze(analyzer);
-        // disallow external catalog
-        Util.prohibitExternalCatalog(tableName.getCtl(), 
this.getClass().getSimpleName());
+
+        if (!Env.getCurrentEnv().getAccessManager()

Review Comment:
   Better to use this method `public boolean checkTblPriv(UserIdentity 
currentUser, String ctl, String db, String tbl, PrivPredicate wanted)` to and 
pass all `catalog`, `database` and `table` info



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to