BiteTheDDDDt commented on code in PR #28352:
URL: https://github.com/apache/doris/pull/28352#discussion_r1429625082
##########
regression-test/suites/query_p0/sql_functions/string_functions/test_string_function.groovy:
##########
@@ -140,8 +140,76 @@ suite("test_string_function", "arrow_flight_sql") {
qt_sql "select starts_with(\"hello world\",\"world\");"
qt_sql "select starts_with(\"hello world\",null);"
- qt_sql "select strleft(\"Hello doris\",5);"
- qt_sql "select strright(\"Hello doris\",5);"
+ qt_sql "select strleft(NULL, 1);"
+ qt_sql "select strleft(\"good morning\", NULL);"
+ qt_sql "select left(NULL, 1);"
Review Comment:
add case for invalid input
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
