xzj7019 commented on code in PR #28017: URL: https://github.com/apache/doris/pull/28017#discussion_r1427565267
########## regression-test/data/nereids_rules_p0/filter_push_down/push_down_filter_other_condition.out: ########## @@ -1,382 +1,253 @@ -- This file is automatically generated. You should know what you did if you want to edit this -- !pushdown_inner_join -- PhysicalResultSink ---PhysicalDistribute -----PhysicalProject -------hashJoin[INNER_JOIN] hashCondition=((t1.id = t2.id)) otherCondition=() build RFs:RF0 id->[id] ---------filter((t1.id > 1)) -----------PhysicalOlapScan[t1] apply RFs: RF0 ---------PhysicalDistribute -----------filter((t2.id > 1)) -------------PhysicalOlapScan[t2] +--hashJoin[INNER_JOIN] hashCondition=((t1.id = t2.id)) otherCondition=() build RFs:RF0 id->[id] Review Comment: need to confirm ########## regression-test/data/nereids_tpcds_shape_sf1000_p0/shape/query10.out: ########## @@ -5,53 +5,50 @@ PhysicalResultSink ----PhysicalTopN[MERGE_SORT] ------PhysicalDistribute --------PhysicalTopN[LOCAL_SORT] -----------hashAgg[GLOBAL] -------------PhysicalDistribute ---------------hashAgg[LOCAL] -----------------PhysicalProject -------------------hashJoin[RIGHT_SEMI_JOIN] hashCondition=((c.c_customer_sk = store_sales.ss_customer_sk)) otherCondition=() build RFs:RF5 c_customer_sk->[ss_customer_sk] ---------------------PhysicalDistribute -----------------------PhysicalProject -------------------------hashJoin[INNER_JOIN] hashCondition=((store_sales.ss_sold_date_sk = date_dim.d_date_sk)) otherCondition=() build RFs:RF4 d_date_sk->[ss_sold_date_sk] +----------hashAgg[LOCAL] Review Comment: need to confirm ########## regression-test/data/nereids_rules_p0/eager_aggregate/basic_one_side.out: ########## @@ -1,60 +1,40 @@ -- This file is automatically generated. You should know what you did if you want to edit this -- !1 -- PhysicalResultSink ---PhysicalDistribute -----hashAgg[GLOBAL] -------PhysicalDistribute +--hashAgg[GLOBAL] +----hashAgg[LOCAL] Review Comment: need to confirm ########## regression-test/data/nereids_rules_p0/eager_aggregate/basic.out: ########## @@ -1,63 +1,43 @@ -- This file is automatically generated. You should know what you did if you want to edit this -- !1 -- PhysicalResultSink ---PhysicalDistribute -----hashAgg[GLOBAL] -------PhysicalDistribute +--hashAgg[GLOBAL] Review Comment: need to confirm ########## regression-test/data/nereids_rules_p0/infer_set_operator_distinct/infer_set_operator_distinct.out: ########## @@ -242,23 +272,27 @@ PhysicalResultSink --------hashAgg[LOCAL] ----------PhysicalUnion ------------PhysicalDistribute ---------------hashJoin[LEFT_SEMI_JOIN] hashCondition=((t1.id = t2.id)) otherCondition=() -----------------PhysicalOlapScan[t1] -----------------PhysicalDistribute -------------------PhysicalProject ---------------------PhysicalOlapScan[t2] +--------------PhysicalProject Review Comment: need to confirm ########## regression-test/suites/nereids_rules_p0/eager_aggregate/basic.groovy: ########## @@ -18,6 +18,7 @@ suite("eager_aggregate_basic") { sql "SET enable_nereids_planner=true" sql "SET enable_fallback_to_original_planner=false" + sql "SET ignore_shape_nodes='PhysicalDistribute,PhysicalProject'" Review Comment: need to confirm ########## regression-test/data/nereids_rules_p0/predicate_infer/infer_predicate.out: ########## @@ -1,565 +1,397 @@ -- This file is automatically generated. You should know what you did if you want to edit this -- !infer_predicate_basic_join -- PhysicalResultSink ---PhysicalDistribute -----PhysicalProject -------hashJoin[INNER_JOIN] hashCondition=((t1.id = t2.id)) otherCondition=() build RFs:RF0 id->[id] ---------PhysicalOlapScan[t] apply RFs: RF0 ---------filter((t1.score > 10)) -----------PhysicalOlapScan[t] +--hashJoin[INNER_JOIN] hashCondition=((t1.id = t2.id)) otherCondition=() Review Comment: need to confirm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org