XieJiann commented on code in PR #28348:
URL: https://github.com/apache/doris/pull/28348#discussion_r1427480947
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java:
##########
@@ -405,6 +406,8 @@ private static List<RewriteJob>
getWholeTreeRewriteJobs(List<RewriteJob> jobs) {
topic("rewrite cte sub-tree",
custom(RuleType.REWRITE_CTE_CHILDREN, () -> new
RewriteCteChildren(jobs))
),
+ topic("or expansion",
Review Comment:
Because `or expansion` could generate new CTE, it may break the assumption
that the CTE anchor always is at the top of the plam
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java:
##########
@@ -405,6 +406,8 @@ private static List<RewriteJob>
getWholeTreeRewriteJobs(List<RewriteJob> jobs) {
topic("rewrite cte sub-tree",
custom(RuleType.REWRITE_CTE_CHILDREN, () -> new
RewriteCteChildren(jobs))
),
+ topic("or expansion",
Review Comment:
Because `or expansion` could generate new CTE, it may break the assumption
that the CTE anchor always is at the top of the plan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
