github-actions[bot] commented on code in PR #28372: URL: https://github.com/apache/doris/pull/28372#discussion_r1426734921
########## be/src/runtime/buffer_control_block.h: ########## @@ -104,6 +104,12 @@ class BufferControlBlock { } } + void update_total_return_rows(int64_t rows) { Review Comment: warning: method 'update_total_return_rows' can be made static [readability-convert-member-functions-to-static] ```suggestion static void update_total_return_rows(int64_t rows) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org