github-actions[bot] commented on code in PR #28416: URL: https://github.com/apache/doris/pull/28416#discussion_r1426495277
########## be/src/pipeline/pipeline_x/local_exchange/local_exchange_source_operator.h: ########## @@ -80,6 +80,9 @@ class LocalExchangeSourceOperatorX final : public OperatorX<LocalExchangeSourceL bool is_source() const override { return true; } + // If input data distribution is ignored by this fragment, this first local exchange source in this fragment will re-assign all data. + bool ignore_data_distribution() const override { return false; } Review Comment: warning: method 'ignore_data_distribution' can be made static [readability-convert-member-functions-to-static] ```suggestion static bool ignore_data_distribution() override { return false; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org