JNSimba commented on code in PR #270:
URL: 
https://github.com/apache/doris-flink-connector/pull/270#discussion_r1426241481


##########
flink-doris-connector/src/test/java/org/apache/doris/flink/itcase/DorisSinkITCase.java:
##########


Review Comment:
   Yes, I have also considered separating the module separately, but I think it 
may increase the complexity. Moreover, referring to other Flink Connectors, 
they are all written directly in Test. What is your main influence here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to