github-actions[bot] commented on code in PR #28383:
URL: https://github.com/apache/doris/pull/28383#discussion_r1426198685
##########
be/src/vec/exec/scan/scanner_context.h:
##########
@@ -192,6 +186,12 @@ class ScannerContext {
Status _close_and_clear_scanners(Parent* parent, RuntimeState* state);
protected:
+ ScannerContext(RuntimeState* state_, const TupleDescriptor*
output_tuple_desc,
+ const std::list<VScannerSPtr>& scanners_, int64_t limit_,
+ int64_t max_bytes_in_blocks_queue_, const int
num_parallel_instances,
Review Comment:
warning: parameter 'num_parallel_instances' is const-qualified in the
function declaration; const-qualification of parameters only has an effect in
function definitions [readability-avoid-const-params-in-decls]
```suggestion
int64_t max_bytes_in_blocks_queue_, int
num_parallel_instances,
```
##########
be/src/vec/exec/scan/scanner_context.cpp:
##########
@@ -45,6 +45,48 @@ namespace doris::vectorized {
using namespace std::chrono_literals;
+ScannerContext::ScannerContext(RuntimeState* state_, const TupleDescriptor*
output_tuple_desc,
+ const std::list<VScannerSPtr>& scanners_,
int64_t limit_,
+ int64_t max_bytes_in_blocks_queue_, const int
num_parallel_instances,
+ pipeline::ScanLocalStateBase* local_state,
+ std::shared_ptr<pipeline::ScanDependency>
dependency,
+ std::shared_ptr<pipeline::Dependency>
finish_dependency)
+ : _state(state_),
+ _parent(nullptr),
Review Comment:
warning: member initializer for '_parent' is redundant
[modernize-use-default-member-init]
```suggestion
,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
