zclllyybb commented on code in PR #28352: URL: https://github.com/apache/doris/pull/28352#discussion_r1426157995
########## be/src/vec/functions/function_string.h: ########## @@ -581,7 +588,22 @@ class FunctionLeft : public IFunction { temp_arguments[0] = arguments[0]; temp_arguments[1] = num_columns_without_result; temp_arguments[2] = arguments[1]; - SubstringUtil::substring_execute(block, temp_arguments, result, input_rows_count); + + bool is_nullable {}; Review Comment: it will be more clear if change to ```suggestion bool is_nullable = nullptr; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org