yujun777 commented on code in PR #28138:
URL: https://github.com/apache/doris/pull/28138#discussion_r1425251642
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ModifyTablePropertiesClause.java:
##########
@@ -99,7 +101,8 @@ public void analyze(Analyzer analyzer) throws
AnalysisException {
throw new AnalysisException(
"Property " +
PropertyAnalyzer.PROPERTIES_STORAGE_FORMAT + " should be v2");
}
- } else if
(DynamicPartitionUtil.checkDynamicPartitionPropertiesExist(properties)) {
+ } else if
(DynamicPartitionUtil.checkDynamicPartitionPropertiesExist(properties)
+ &&
DynamicPartitionUtil.checkDynamicPartitionPropertiesAllValid(properties)) {
Review Comment:
else if
(DynamicPartitionUtil.checkDynamicPartitionPropertiesExist(properties)) {
if
(!DynamicPartitionUtil.checkDynamicPartitionPropertiesAllValid(properties)) {
throws exception ...
}
} ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
