morningman commented on code in PR #28325:
URL: https://github.com/apache/doris/pull/28325#discussion_r1424843472
##########
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Auth.java:
##########
@@ -960,6 +960,12 @@ public void updateUserPropertyInternal(String user,
List<Pair<String, String>> p
Env.getCurrentEnv().getEditLog().logUpdateUserProperty(propertyInfo);
}
LOG.info("finished to set properties for user: {}", user);
+ } catch (DdlException e) {
+ if (isReplay && e.getMessage().contains("Unknown user property")) {
+ LOG.warn("ReplayUpdateUserProperty failed, maybe FE rolled
back version, " + e.getMessage());
Review Comment:
```suggestion
LOG.warn("ReplayUpdateUserProperty failed, maybe FE rolled
back version. Ignore it" + e.getMessage());
```
##########
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Auth.java:
##########
@@ -960,6 +960,12 @@ public void updateUserPropertyInternal(String user,
List<Pair<String, String>> p
Env.getCurrentEnv().getEditLog().logUpdateUserProperty(propertyInfo);
}
LOG.info("finished to set properties for user: {}", user);
+ } catch (DdlException e) {
+ if (isReplay && e.getMessage().contains("Unknown user property")) {
Review Comment:
How about define a new Exception, not using `error message` to check?
And some some comment about how can it happen and why it can be ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
