github-actions[bot] commented on code in PR #28318:
URL: https://github.com/apache/doris/pull/28318#discussion_r1424798877
##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -700,5 +704,63 @@
return same;
}
+Status Segment::seek_and_read_by_rowid(const TabletSchema& schema,
SlotDescriptor* slot,
Review Comment:
warning: method 'seek_and_read_by_rowid' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status Segment::seek_and_read_by_rowid(const TabletSchema& schema,
SlotDescriptor* slot,
```
##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -332,17 +334,18 @@ Status Segment::_load_index_impl() {
// Return the storage datatype of related column to field.
// Return nullptr meaning no such storage infomation for this column
-vectorized::DataTypePtr Segment::get_data_type_of(const Field& field, bool
ignore_children) const {
+vectorized::DataTypePtr Segment::get_data_type_of(vectorized::PathInData path,
bool is_nullable,
Review Comment:
warning: method 'get_data_type_of' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/rowset/segment_v2/segment.cpp:337:
```diff
- bool ignore_children)
const {
+ bool ignore_children) {
```
be/src/olap/rowset/segment_v2/segment.h:155:
```diff
- std::shared_ptr<const vectorized::IDataType>
get_data_type_of(vectorized::PathInData path,
+ static std::shared_ptr<const vectorized::IDataType>
get_data_type_of(vectorized::PathInData path,
```
be/src/olap/rowset/segment_v2/segment.h:157:
```diff
- bool
ignore_children) const;
+ bool
ignore_children) ;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
