This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new eda2818b95b [fix](group commit) Fix
insert_group_commit_into_unique_sync_mode (#28283)
eda2818b95b is described below
commit eda2818b95bd4e4610ad7b213862909c55a040c5
Author: meiyi <myime...@gmail.com>
AuthorDate: Wed Dec 13 01:12:57 2023 +0800
[fix](group commit) Fix insert_group_commit_into_unique_sync_mode (#28283)
---
.../insert_group_commit_into_max_filter_ratio.groovy | 6 +++++-
.../insert_group_commit_into_unique_sync_mode.groovy | 17 ++++++++++++++---
2 files changed, 19 insertions(+), 4 deletions(-)
diff --git
a/regression-test/suites/insert_p0/insert_group_commit_into_max_filter_ratio.groovy
b/regression-test/suites/insert_p0/insert_group_commit_into_max_filter_ratio.groovy
index 02f3ca1e7a9..51264d3d863 100644
---
a/regression-test/suites/insert_p0/insert_group_commit_into_max_filter_ratio.groovy
+++
b/regression-test/suites/insert_p0/insert_group_commit_into_max_filter_ratio.groovy
@@ -218,7 +218,11 @@ suite("insert_group_commit_into_max_filter_ratio") {
sql """ set enable_insert_strict = false; """
group_commit_insert """ insert into ${dbTableName} values (9, 'a',
'a'); """, 0
}
- get_row_count_with_retry(4 + item == "nereids" ? 2 : 0)
+ if (item == "nereids") {
+ get_row_count_with_retry(6)
+ } else {
+ get_row_count_with_retry(4)
+ }
order_qt_sql """ select * from ${dbTableName} """
}
sql """ truncate table ${tableName} """
diff --git
a/regression-test/suites/insert_p0/insert_group_commit_into_unique_sync_mode.groovy
b/regression-test/suites/insert_p0/insert_group_commit_into_unique_sync_mode.groovy
index d278653ac1f..0d727b9ec44 100644
---
a/regression-test/suites/insert_p0/insert_group_commit_into_unique_sync_mode.groovy
+++
b/regression-test/suites/insert_p0/insert_group_commit_into_unique_sync_mode.groovy
@@ -22,10 +22,21 @@ suite("insert_group_commit_into_unique_sync_mode") {
def tableName = "insert_group_commit_into_unique_sync"
def dbTableName = dbName + "." + tableName
+ // For sync mode mode, the rows should be visible once the load is
finished,
+ // but we meet publish_timeout sometimes
def getRowCount = { expectedRowCount ->
- def rowCount = sql "select count(*) from ${dbTableName}"
- logger.info("rowCount: " + rowCount + ", expecedRowCount: " +
expectedRowCount)
- assertEquals(expectedRowCount, rowCount[0][0])
+ def retry = 0
+ while (retry < 30) {
+ if (retry > 0) {
+ sleep(1000)
+ }
+ def rowCount = sql "select count(*) from ${dbTableName}"
+ logger.info("rowCount: " + rowCount + ", retry: " + retry)
+ if (rowCount[0][0] >= expectedRowCount) {
+ break
+ }
+ retry++
+ }
}
def group_commit_insert = { sql, expected_row_count ->
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
