This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 78cf401c92a [enhancement](err-msg) expose real error msg for invalid
delete conf (#28287)
78cf401c92a is described below
commit 78cf401c92a18fb2dd081dc258adffb222e69ff4
Author: Siyang Tang <82279870+tangsiyang2...@users.noreply.github.com>
AuthorDate: Wed Dec 13 01:07:31 2023 +0800
[enhancement](err-msg) expose real error msg for invalid delete conf
(#28287)
---
be/src/olap/delete_handler.cpp | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/be/src/olap/delete_handler.cpp b/be/src/olap/delete_handler.cpp
index 67100e680dc..f8b22b6a0d7 100644
--- a/be/src/olap/delete_handler.cpp
+++ b/be/src/olap/delete_handler.cpp
@@ -31,6 +31,7 @@
#include "common/config.h"
#include "common/logging.h"
+#include "common/status.h"
#include "olap/block_column_predicate.h"
#include "olap/column_predicate.h"
#include "olap/olap_common.h"
@@ -63,11 +64,7 @@ Status DeleteHandler::generate_delete_predicate(const
TabletSchema& schema,
// Check whether the delete condition meets the requirements
for (const TCondition& condition : conditions) {
- if (!check_condition_valid(schema, condition).ok()) {
- // Error will print log, no need to do it manually.
- return Status::Error<DELETE_INVALID_CONDITION>("invalid condition.
condition={}",
-
ThriftDebugString(condition));
- }
+ RETURN_IF_ERROR(check_condition_valid(schema, condition));
}
// Store delete condition
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
