julic20s commented on PR #28200: URL: https://github.com/apache/doris/pull/28200#issuecomment-1852322550
@yiguolei My mistake. Add the macro is meaningless now. When the number to be divided is Int128, the libdivide will not be used. (libdivide supports for (i128 / x) but (x / int128) is not supported. Maybe `DivideIntegralImpl` should check it more carefully?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
