yiguolei commented on code in PR #28223:
URL: https://github.com/apache/doris/pull/28223#discussion_r1423980480
##########
be/src/vec/exec/scan/scanner_context.h:
##########
@@ -272,6 +272,8 @@ class ScannerContext {
// Not need to protect by lock, because only one scheduler thread will
access to it.
std::mutex _scanners_lock;
std::list<VScannerSPtr> _scanners;
+ // weak pointer for _scanners, used in stop function
+ std::vector<VScannerWPtr> _scanners_ref;
Review Comment:
There is already a std::list<VScannerSPtr> _scanners;
why do we need a weak ptr here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
