mrhhsg commented on code in PR #28258:
URL: https://github.com/apache/doris/pull/28258#discussion_r1423362671
##########
be/src/vec/exec/join/vhash_join_node.cpp:
##########
@@ -1080,6 +1082,15 @@ Status HashJoinNode::_extract_join_column(Block& block,
ColumnUInt8::MutablePtr&
raw_ptrs[i] = &col_nested;
}
} else {
+ if constexpr (!BuildSide) {
+ if (_join_op == TJoinOp::RIGHT_ANTI_JOIN &&
Review Comment:
Yes, right join and ful join will be converted in `_convert_block_to_null`.
##########
be/src/vec/exec/join/vhash_join_node.cpp:
##########
@@ -1080,6 +1082,15 @@ Status HashJoinNode::_extract_join_column(Block& block,
ColumnUInt8::MutablePtr&
raw_ptrs[i] = &col_nested;
}
} else {
+ if constexpr (!BuildSide) {
+ if (_join_op == TJoinOp::RIGHT_ANTI_JOIN &&
Review Comment:
Yes, right join and full join will be converted in `_convert_block_to_null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
