github-actions[bot] commented on code in PR #28260:
URL: https://github.com/apache/doris/pull/28260#discussion_r1423005028
##########
be/src/vec/columns/column_nullable.cpp:
##########
@@ -47,9 +48,24 @@ ColumnNullable::ColumnNullable(MutableColumnPtr&&
nested_column_, MutableColumnP
if (is_column_const(*null_map)) {
LOG(FATAL) << "ColumnNullable cannot have constant null map";
}
+
+ if (update_null_data_) {
+ update_null_data();
+ }
+
_need_update_has_null = true;
}
+void ColumnNullable::update_null_data() {
Review Comment:
warning: method 'update_null_data' can be made const
[readability-make-member-function-const]
```suggestion
void ColumnNullable::update_null_data() const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
