zhannngchen commented on code in PR #28012:
URL: https://github.com/apache/doris/pull/28012#discussion_r1418619022


##########
be/src/olap/task/engine_publish_version_task.cpp:
##########
@@ -191,8 +191,16 @@ Status EnginePublishVersionTask::execute() {
                     }
                     auto handle_version_not_continuous = [&]() {
                         add_error_tablet_id(tablet_info.tablet_id);
-                        _discontinuous_version_tablets->emplace_back(
-                                partition_id, tablet_info.tablet_id, 
version.first);
+                        // When there are too many missing versions, do not 
directly retry the
+                        // publish and handle it through async publish.
+                        if (max_version + 20 < version.first) {

Review Comment:
   We'd better make this number configurable so that in case there's an issue 
with this strategy, users can adjust the configuration to work around it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to