github-actions[bot] commented on code in PR #28257:
URL: https://github.com/apache/doris/pull/28257#discussion_r1422505131
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.cpp:
##########
@@ -495,6 +541,24 @@
return Status::OK();
}
+Status FullTextIndexReader::match_regexp_index_search(
Review Comment:
warning: method 'match_regexp_index_search' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status FullTextIndexReader::match_regexp_index_search(
```
##########
be/src/vec/functions/match.h:
##########
@@ -145,6 +145,23 @@ class FunctionMatchPhrasePrefix : public FunctionMatchBase
{
}
};
+class FunctionMatchRegexp : public FunctionMatchBase {
+public:
+ static constexpr auto name = "match_regexp";
+ static FunctionPtr create() { return
std::make_shared<FunctionMatchRegexp>(); }
+
+ String get_name() const override { return name; }
+
+ Status execute_match(const std::string& column_name, const std::string&
match_query_str,
Review Comment:
warning: method 'execute_match' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status execute_match(const std::string& column_name, const
std::string& match_query_str,
```
be/src/vec/functions/match.h:158:
```diff
- ColumnUInt8::Container& result) const override {
+ ColumnUInt8::Container& result) override {
```
##########
be/src/olap/rowset/segment_v2/inverted_index_reader.cpp:
##########
@@ -134,10 +136,13 @@ std::unique_ptr<lucene::util::Reader>
InvertedIndexReader::create_reader(
return reader;
}
-std::vector<std::string> InvertedIndexReader::get_analyse_result(
- lucene::util::Reader* reader, lucene::analysis::Analyzer* analyzer,
- const std::string& field_name, InvertedIndexQueryType query_type, bool
drop_duplicates) {
- std::vector<std::string> analyse_result;
+void InvertedIndexReader::get_analyse_result(std::vector<std::string>&
analyse_result,
Review Comment:
warning: method 'get_analyse_result' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void
InvertedIndexReader::get_analyse_result(std::vector<std::string>&
analyse_result,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
