JNSimba commented on code in PR #265:
URL:
https://github.com/apache/doris-flink-connector/pull/265#discussion_r1422189851
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/RowDataSerializer.java:
##########
@@ -40,12 +53,18 @@
* Serializer for RowData.
*/
public class RowDataSerializer implements DorisRecordSerializer<RowData> {
Review Comment:
It is recommended to write an arrow ut in TestRowDataSerializer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
