github-actions[bot] commented on code in PR #27720:
URL: https://github.com/apache/doris/pull/27720#discussion_r1421747484
##########
be/src/runtime/group_commit_mgr.cpp:
##########
@@ -420,9 +420,12 @@ void GroupCommitMgr::stop() {
LOG(INFO) << "GroupCommitMgr is stopped";
}
-Status GroupCommitMgr::get_first_block_load_queue(
- int64_t db_id, int64_t table_id,
std::shared_ptr<vectorized::FutureBlock> block,
- std::shared_ptr<LoadBlockQueue>& load_block_queue) {
+Status GroupCommitMgr::get_first_block_load_queue(int64_t db_id, int64_t
table_id,
Review Comment:
warning: method 'get_first_block_load_queue' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/group_commit_mgr.h:141:
```diff
- Status get_first_block_load_queue(int64_t db_id, int64_t table_id,
int64_t base_schema_version,
+ static Status get_first_block_load_queue(int64_t db_id, int64_t
table_id, int64_t base_schema_version,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
