morningman commented on a change in pull request #5700:
URL: https://github.com/apache/incubator-doris/pull/5700#discussion_r623930399
##########
File path: be/src/util/string_util.cpp
##########
@@ -18,14 +18,15 @@
#include "util/string_util.h"
#include "gutil/strings/split.h"
+#include "util/hash_util.hpp"
namespace doris {
size_t hash_of_path(const std::string& identifier, const std::string& path) {
size_t hash = std::hash<std::string>()(identifier);
std::vector<std::string> path_parts = strings::Split(path, "/",
strings::SkipWhitespace());
for (auto& part : path_parts) {
- boost::hash_combine<std::string>(hash, part);
+ HashUtil::hash_combine<std::string>(hash, part);
Review comment:
Is it exactly same as `boost::hash_combine`?
##########
File path: be/src/util/hash_util.hpp
##########
@@ -323,14 +337,18 @@ class HashUtil {
murmur_hash3_x64_64(data, bytes, seed, &hash);
return hash;
#endif
-
+ }
+ template <class T>
Review comment:
add comment to explain where does this code comes from
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
