ruancomelli commented on code in PR #27979:
URL: https://github.com/apache/doris/pull/27979#discussion_r1420370855
##########
be/src/runtime/exec_env_init.cpp:
##########
@@ -553,7 +553,7 @@ void ExecEnv::destroy() {
SAFE_STOP(_external_scan_context_mgr);
SAFE_STOP(_fragment_mgr);
SAFE_STOP(_runtime_filter_timer_queue);
- // NewLoadStreamMgr should be destoried before storage_engine & after
fragment_mgr stopped.
+ // NewLoadStreamMgr should be destroied before storage_engine & after
fragment_mgr stopped.
Review Comment:
```suggestion
// NewLoadStreamMgr should be destroyed before storage_engine & after
fragment_mgr stopped.
```
##########
be/src/runtime/exec_env_init.cpp:
##########
@@ -590,15 +590,15 @@ void ExecEnv::destroy() {
SAFE_DELETE(_segment_loader);
SAFE_DELETE(_row_cache);
- // StorageEngine must be destoried before _page_no_cache_mem_tracker.reset
- // StorageEngine must be destoried before _cache_manager destory
+ // StorageEngine must be destroied before _page_no_cache_mem_tracker.reset
+ // StorageEngine must be destroied before _cache_manager destroy
Review Comment:
```suggestion
// StorageEngine must be destroyed before
_page_no_cache_mem_tracker.reset
// StorageEngine must be destroyed before _cache_manager destroy
```
##########
be/src/runtime/exec_env_init.cpp:
##########
@@ -590,15 +590,15 @@ void ExecEnv::destroy() {
SAFE_DELETE(_segment_loader);
SAFE_DELETE(_row_cache);
- // StorageEngine must be destoried before _page_no_cache_mem_tracker.reset
- // StorageEngine must be destoried before _cache_manager destory
+ // StorageEngine must be destroied before _page_no_cache_mem_tracker.reset
+ // StorageEngine must be destroied before _cache_manager destroy
SAFE_DELETE(_storage_engine);
// _scanner_scheduler must be desotried before _storage_page_cache
SAFE_DELETE(_scanner_scheduler);
- // _storage_page_cache must be destoried before _cache_manager
+ // _storage_page_cache must be destroied before _cache_manager
SAFE_DELETE(_storage_page_cache);
- // cache_manager must be destoried after _inverted_index_query_cache
+ // cache_manager must be destroied after _inverted_index_query_cache
Review Comment:
```suggestion
// cache_manager must be destroyed after _inverted_index_query_cache
```
##########
be/src/olap/wal_manager.cpp:
##########
@@ -45,7 +45,7 @@ WalManager::WalManager(ExecEnv* exec_env, const std::string&
wal_dir_list)
}
WalManager::~WalManager() {
- LOG(INFO) << "WalManager is destoried";
+ LOG(INFO) << "WalManager is destroied";
Review Comment:
I'm afraid this is still not right... the correct spelling is
`destroy`/`destroyed`:
```suggestion
LOG(INFO) << "WalManager is destroyed";
```
##########
be/src/runtime/exec_env_init.cpp:
##########
@@ -590,15 +590,15 @@ void ExecEnv::destroy() {
SAFE_DELETE(_segment_loader);
SAFE_DELETE(_row_cache);
- // StorageEngine must be destoried before _page_no_cache_mem_tracker.reset
- // StorageEngine must be destoried before _cache_manager destory
+ // StorageEngine must be destroied before _page_no_cache_mem_tracker.reset
+ // StorageEngine must be destroied before _cache_manager destroy
SAFE_DELETE(_storage_engine);
// _scanner_scheduler must be desotried before _storage_page_cache
SAFE_DELETE(_scanner_scheduler);
- // _storage_page_cache must be destoried before _cache_manager
+ // _storage_page_cache must be destroied before _cache_manager
Review Comment:
```suggestion
// _storage_page_cache must be destroyed before _cache_manager
```
##########
be/src/runtime/exec_env_init.cpp:
##########
@@ -640,7 +640,7 @@ void ExecEnv::destroy() {
_serial_download_cache_thread_token.reset(nullptr);
_download_cache_thread_pool.reset(nullptr);
- // _heartbeat_flags must be destoried after staroge engine
+ // _heartbeat_flags must be destroied after staroge engine
Review Comment:
```suggestion
// _heartbeat_flags must be destroyed after storage engine
```
##########
be/src/runtime/exec_env_init.cpp:
##########
@@ -649,7 +649,7 @@ void ExecEnv::destroy() {
// info is deconstructed then BE process will core at coordinator back
method in fragment mgr.
SAFE_DELETE(_master_info);
- LOG(INFO) << "Doris exec envorinment is destoried.";
+ LOG(INFO) << "Doris exec envorinment is destroied.";
Review Comment:
```suggestion
LOG(INFO) << "Doris exec environment is destroyed.";
```
##########
be/src/runtime/group_commit_mgr.cpp:
##########
@@ -412,7 +412,7 @@ GroupCommitMgr::GroupCommitMgr(ExecEnv* exec_env) :
_exec_env(exec_env) {
}
GroupCommitMgr::~GroupCommitMgr() {
- LOG(INFO) << "GroupCommitMgr is destoried";
+ LOG(INFO) << "GroupCommitMgr is destroied";
Review Comment:
```suggestion
LOG(INFO) << "GroupCommitMgr is destroyed";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
