xzj7019 commented on code in PR #27833:
URL: https://github.com/apache/doris/pull/27833#discussion_r1419907739
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java:
##########
@@ -262,6 +265,20 @@ public Cost visitPhysicalHashJoin(
double leftRowCount = probeStats.getRowCount();
double rightRowCount = buildStats.getRowCount();
+ // if the diff of the left side and right side row count is
+ // less than this threshold, we will consider their connectivity
+ double ignorableDiffBetweenLeftAndRightThreshold = 10.0;
+ if (Math.abs(leftRowCount - rightRowCount) <
ignorableDiffBetweenLeftAndRightThreshold
Review Comment:
better to restrict this corn case to left row count equals to right count
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
