github-actions[bot] commented on code in PR #27829: URL: https://github.com/apache/doris/pull/27829#discussion_r1419870277
########## be/src/pipeline/pipeline_x/pipeline_x_fragment_context.cpp: ########## @@ -565,20 +591,21 @@ Status PipelineXFragmentContext::_build_pipeline_tasks( pipeline_id_to_task[dep]->get_downstream_dependency()); } } - RETURN_IF_ERROR(prepare_and_set_parent_profile(task)); + RETURN_IF_ERROR(prepare_and_set_parent_profile(task, pip_idx)); } - { std::lock_guard<std::mutex> l(_state_map_lock); _instance_id_to_runtime_state.insert( {UniqueId(_runtime_states[i]->fragment_instance_id()), _runtime_states[i].get()}); + _runtime_filter_mgr_map[_runtime_states[i]->per_fragment_instance_idx()] = + std::move(runtime_filter_mgr); } } _pipeline_parent_map.clear(); _dag.clear(); _op_id_to_le_state.clear(); - + if(_enable_local_shuffle()) return Status::OK(); Review Comment: warning: statement should be inside braces [readability-braces-around-statements] ```suggestion if(_enable_local_shuffle()) { return Status::OK(); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org