github-actions[bot] commented on code in PR #28157:
URL: https://github.com/apache/doris/pull/28157#discussion_r1419817542
##########
be/src/vec/columns/column_object.h:
##########
@@ -279,9 +279,13 @@ class ColumnObject final : public COWHelper<IColumn,
ColumnObject> {
const Subcolumn* get_subcolumn(const PathInData& key) const;
/** More efficient methods of manipulation */
- [[noreturn]] IColumn& get_data() { LOG(FATAL) << "Not implemented method
get_data()"; }
+ [[noreturn]] IColumn& get_data() {
Review Comment:
warning: method 'get_data' can be made static
[readability-convert-member-functions-to-static]
```suggestion
[[noreturn]] static IColumn& get_data() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
