github-actions[bot] commented on code in PR #28126: URL: https://github.com/apache/doris/pull/28126#discussion_r1418956058
########## be/src/pipeline/exec/sort_sink_operator.h: ########## @@ -94,6 +94,13 @@ class SortSinkOperatorX final : public DataSinkOperatorX<SortSinkLocalState> { Status sink(RuntimeState* state, vectorized::Block* in_block, SourceState source_state) override; + ExchangeType get_local_exchange_type() const override { Review Comment: warning: method 'get_local_exchange_type' can be made static [readability-convert-member-functions-to-static] ```suggestion static ExchangeType get_local_exchange_type() override { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org