github-actions[bot] commented on code in PR #26537:
URL: https://github.com/apache/doris/pull/26537#discussion_r1418721350
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -460,11 +491,11 @@ Status
BetaRowsetWriter::flush_memtable(vectorized::Block* block, int32_t segmen
return Status::OK();
}
-Status BetaRowsetWriter::flush_single_block(const vectorized::Block* block) {
+Status BaseBetaRowsetWriter::flush_single_block(const vectorized::Block*
block) {
return _segment_creator.flush_single_block(block);
}
-Status BetaRowsetWriter::wait_flying_segcompaction() {
+Status BetaRowsetWriter::_wait_flying_segcompaction() {
Review Comment:
warning: method '_wait_flying_segcompaction' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/rowset/beta_rowset_writer.h:206:
```diff
- Status _wait_flying_segcompaction();
+ static Status _wait_flying_segcompaction();
```
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -541,25 +583,19 @@
return Status::OK();
}
-bool BetaRowsetWriter::_is_segment_overlapping(
- const std::vector<KeyBoundsPB>& segments_encoded_key_bounds) {
- std::string last;
- for (auto segment_encode_key : segments_encoded_key_bounds) {
- auto cur_min = segment_encode_key.min_key();
- auto cur_max = segment_encode_key.max_key();
- if (cur_min <= last) {
- return true;
- }
- last = cur_max;
- }
- return false;
+int64_t BaseBetaRowsetWriter::_num_seg() const {
+ return _num_segment;
+}
+
+int64_t BetaRowsetWriter::_num_seg() const {
+ return _is_segcompacted() ? _num_segcompacted : _num_segment;
}
// update tablet schema when meet variant columns, before commit_txn
// Eg. rowset schema: A(int), B(float), C(int), D(int)
// _tabelt->tablet_schema: A(bigint), B(double)
// => update_schema: A(bigint), B(double), C(int), D(int)
-void BetaRowsetWriter::update_rowset_schema(TabletSchemaSPtr flush_schema) {
+void BaseBetaRowsetWriter::update_rowset_schema(TabletSchemaSPtr flush_schema)
{
Review Comment:
warning: method 'update_rowset_schema' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/rowset/beta_rowset_writer.h:134:
```diff
- void update_rowset_schema(TabletSchemaSPtr flush_schema);
+ static void update_rowset_schema(TabletSchemaSPtr flush_schema);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
