github-actions[bot] commented on code in PR #28062:
URL: https://github.com/apache/doris/pull/28062#discussion_r1418568157
##########
be/src/olap/olap_common.h:
##########
@@ -493,13 +493,18 @@ inline RowsetId extract_rowset_id(std::string_view
filename) {
class DeleteBitmap;
// merge on write context
struct MowContext {
- MowContext(int64_t version, int64_t txnid, const RowsetIdUnorderedSet& ids,
+ MowContext(int64_t version, int64_t txnid, RowsetIdUnorderedSet& ids,
std::shared_ptr<DeleteBitmap> db)
: max_version(version), txn_id(txnid), rowset_ids(ids),
delete_bitmap(db) {}
+ void update_rowset_ids_with_lock(std::function<void()> callback) {
Review Comment:
warning: method 'update_rowset_ids_with_lock' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void update_rowset_ids_with_lock(std::function<void()> callback) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
