github-actions[bot] commented on code in PR #27726:
URL: https://github.com/apache/doris/pull/27726#discussion_r1418509959
##########
be/src/olap/wal_writer.cpp:
##########
@@ -133,4 +137,16 @@ Status WalWriter::append_header(uint32_t version,
std::string col_ids) {
return Status::OK();
}
+std::string WalWriter::_get_base_path(const std::string& wal_path) {
Review Comment:
warning: method '_get_base_path' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/wal_writer.h:57:
```diff
- std::string _get_base_path(const std::string& wal_path);
+ static std::string _get_base_path(const std::string& wal_path);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
