zhiqiang-hhhh commented on code in PR #28069:
URL: https://github.com/apache/doris/pull/28069#discussion_r1418287008
##########
be/src/vec/data_types/serde/data_type_array_serde.cpp:
##########
@@ -299,18 +299,28 @@ void DataTypeArraySerDe::read_column_from_arrow(IColumn&
column, const arrow::Ar
template <bool is_binary_format>
Status DataTypeArraySerDe::_write_column_to_mysql(const IColumn& column,
MysqlRowBuffer<is_binary_format>& result,
- int row_idx, bool col_const)
const {
+ int row_idx_of_mysql, bool
col_const) const {
auto& column_array = assert_cast<const ColumnArray&>(column);
auto& offsets = column_array.get_offsets();
auto& data = column_array.get_data();
bool is_nested_string = data.is_column_string();
- const auto col_index = index_check_const(row_idx, col_const);
+ const auto row_idx_of_col_arr = index_check_const(row_idx_of_mysql,
col_const);
+
+ if (column_array.size() <= row_idx_of_col_arr) {
Review Comment:
Yes, we should add check for all serde if we can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
