SWJTU-ZhangLei commented on code in PR #28101:
URL: https://github.com/apache/doris/pull/28101#discussion_r1418257740


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -2796,6 +2800,30 @@ private void removeHelperNode(String host, int port) {
         helperNodes.removeIf(node -> node.getHost().equals(host) && 
node.getPort() == port);
     }
 
+    private void ensureSafeToDropAliveFollower() throws DdlException {
+        int numFollower = 0;
+        int numAliveFollower = 0;
+        for (Frontend fe : frontends.values()) {
+            if (fe.getRole() == FrontendNodeType.FOLLOWER) {
+                numFollower += 1;
+                if (fe.isAlive()) {

Review Comment:
   Alive status is set by heart mgr,  the latency time is  5 seconds,  In some 
situation, it can not detect fe is down ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to