github-actions[bot] commented on code in PR #25786:
URL: https://github.com/apache/doris/pull/25786#discussion_r1418250623
##########
be/src/runtime/fold_constant_executor.cpp:
##########
@@ -158,96 +158,125 @@ Status FoldConstantExecutor::_prepare_and_open(Context*
ctx) {
return ctx->open(_runtime_state.get());
}
-string FoldConstantExecutor::_get_result(void* src, size_t size, const
TypeDescriptor& type,
+Status FoldConstantExecutor::_get_result(void* src, size_t size, const
TypeDescriptor& type,
Review Comment:
warning: function '_get_result' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
Status FoldConstantExecutor::_get_result(void* src, size_t size, const
TypeDescriptor& type,
^
```
<details>
<summary>Additional context</summary>
**be/src/runtime/fold_constant_executor.cpp:160:** 116 lines including
whitespace and comments (threshold 80)
```cpp
Status FoldConstantExecutor::_get_result(void* src, size_t size, const
TypeDescriptor& type,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
