github-actions[bot] commented on code in PR #28094:
URL: https://github.com/apache/doris/pull/28094#discussion_r1418109297
##########
be/src/exprs/bloom_filter_func.h:
##########
@@ -370,8 +364,8 @@
}
}
- static void find_batch(const BloomFilterAdaptor& bloom_filter,
- const vectorized::ColumnPtr& column, uint8_t*
results) {
+ void find_batch(const BloomFilterAdaptor& bloom_filter, const
vectorized::ColumnPtr& column,
Review Comment:
warning: method 'find_batch' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void find_batch(const BloomFilterAdaptor& bloom_filter, const
vectorized::ColumnPtr& column,
```
##########
be/src/exprs/bloom_filter_func.h:
##########
@@ -333,22 +338,11 @@ struct CommonFindOp : BaseOp {
void insert(BloomFilterAdaptor& bloom_filter, const void* data) const {
bloom_filter.add_element(*(T*)data);
}
-
- bool find_olap_engine(const BloomFilterAdaptor& bloom_filter, const void*
data) const override {
- return bloom_filter.test_element(*(T*)data);
- }
};
-struct StringFindOp : public BaseOp {
- uint16_t find_batch_olap_engine(const BloomFilterAdaptor& bloom_filter,
const char* data,
- const uint8* nullmap, uint16_t* offsets,
int number,
- const bool is_parse_column) {
- return find_batch_olap_engine_with_element_size(bloom_filter, data,
nullmap, offsets,
- number,
is_parse_column, sizeof(StringRef));
- }
-
- static void insert_batch(BloomFilterAdaptor& bloom_filter, const
vectorized::ColumnPtr& column,
- size_t start) {
+struct StringFindOp : CommonFindOp<StringRef> {
+ void insert_batch(BloomFilterAdaptor& bloom_filter, const
vectorized::ColumnPtr& column,
Review Comment:
warning: method 'insert_batch' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void insert_batch(BloomFilterAdaptor& bloom_filter, const
vectorized::ColumnPtr& column,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
