yiguolei commented on code in PR #24972:
URL: https://github.com/apache/doris/pull/24972#discussion_r1417109438
##########
be/src/vec/exec/scan/vscanner.cpp:
##########
@@ -167,13 +167,34 @@ Status VScanner::try_append_late_arrival_runtime_filter()
{
// But it is ok because it will be updated at next time.
if (_parent) {
RETURN_IF_ERROR(_parent->clone_conjunct_ctxs(_conjuncts));
+ RETURN_IF_ERROR(_push_late_arrival_runtime_filters());
} else {
+ // TODO: support `_push_late_arrival_runtime_filters` for pipelineX
Review Comment:
有一个地方，我没想明白，当我们下推了之后，在scanner 运行的expr 里是不是就没有了？ 如果有的话，感觉一个谓词被执行了2次运算。
##########
be/src/vec/exec/scan/vscanner.cpp:
##########
@@ -167,13 +167,34 @@ Status VScanner::try_append_late_arrival_runtime_filter()
{
// But it is ok because it will be updated at next time.
if (_parent) {
RETURN_IF_ERROR(_parent->clone_conjunct_ctxs(_conjuncts));
+ RETURN_IF_ERROR(_push_late_arrival_runtime_filters());
} else {
+ // TODO: support `_push_late_arrival_runtime_filters` for pipelineX
Review Comment:
有一个地方，我没想明白，当我们下推了之后，在scanner 运行的expr 里是不是就没有了？ 如果有的话，感觉一个谓词被执行了2次运算。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
