kaka11chen commented on code in PR #26709:
URL: https://github.com/apache/doris/pull/26709#discussion_r1417092707
##########
be/src/vec/data_types/serde/data_type_decimal_serde.cpp:
##########
@@ -167,6 +167,8 @@ void
DataTypeDecimalSerDe<T>::read_column_from_arrow(IColumn& column,
static_cast<const arrow::DecimalType*>(arrow_array->type().get());
const auto arrow_scale = arrow_decimal_type->scale();
auto& column_data = static_cast<ColumnDecimal<T>&>(column).get_data();
+ // Decimal<Int128> for decimalv2
+ // Decimal<Int128I> for deicmalv3
if constexpr (std::is_same_v<T, Decimal<Int128>>) {
Review Comment:
Use `Decimal128` better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
