BiteTheDDDDt commented on code in PR #28069:
URL: https://github.com/apache/doris/pull/28069#discussion_r1417084060
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -156,16 +161,24 @@ Status
VMysqlResultWriter<is_binary_format>::append_block(Block& input_block) {
27);
}
} else {
- serde = block.get_by_position(i).type->get_serde();
+ serde = block.get_by_position(col_idx).type->get_serde();
}
serde->set_return_object_as_string(output_object_data());
arguments.emplace_back(column_ptr.get(), col_const, serde);
}
- for (size_t row_idx = 0; row_idx != num_rows; ++row_idx) {
- for (int i = 0; i < _output_vexpr_ctxs.size(); ++i) {
- RETURN_IF_ERROR(arguments[i].serde->write_column_to_mysql(
- *(arguments[i].column), row_buffer, row_idx,
arguments[i].is_const));
+ for (size_t row_idx = 0; row_idx < num_rows; ++row_idx) {
Review Comment:
Don’t check every row
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -156,16 +161,24 @@ Status
VMysqlResultWriter<is_binary_format>::append_block(Block& input_block) {
27);
}
} else {
- serde = block.get_by_position(i).type->get_serde();
+ serde = block.get_by_position(col_idx).type->get_serde();
}
serde->set_return_object_as_string(output_object_data());
arguments.emplace_back(column_ptr.get(), col_const, serde);
}
- for (size_t row_idx = 0; row_idx != num_rows; ++row_idx) {
- for (int i = 0; i < _output_vexpr_ctxs.size(); ++i) {
- RETURN_IF_ERROR(arguments[i].serde->write_column_to_mysql(
- *(arguments[i].column), row_buffer, row_idx,
arguments[i].is_const));
+ for (size_t row_idx = 0; row_idx < num_rows; ++row_idx) {
Review Comment:
Don’t check every row
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
