github-actions[bot] commented on code in PR #28046:
URL: https://github.com/apache/doris/pull/28046#discussion_r1416710187
##########
be/src/pipeline/pipeline_x/pipeline_x_fragment_context.h:
##########
@@ -154,10 +154,10 @@
const TPipelineFragmentParams& params, const
RowDescriptor& row_desc,
RuntimeState* state, DescriptorTbl& desc_tbl,
PipelineId cur_pipeline_id);
- Status _plan_local_shuffle(int num_buckets,
- const std::map<int, int>&
bucket_seq_to_instance_idx);
- Status _plan_local_shuffle(int num_buckets, int pip_idx, PipelinePtr pip,
- const std::map<int, int>&
bucket_seq_to_instance_idx);
+ Status _plan_local_exchange(int num_buckets,
+ const std::map<int, int>&
bucket_seq_to_instance_idx);
+ Status _plan_local_exchange(int num_buckets, int pip_idx, PipelinePtr pip,
+ const std::map<int, int>&
bucket_seq_to_instance_idx);
Review Comment:
warning: parameter 4 is const-qualified in the function declaration;
const-qualification of parameters only has an effect in function definitions
[readability-avoid-const-params-in-decls]
```suggestion
std::map<int, int>&
bucket_seq_to_instance_idx);
```
##########
be/src/pipeline/pipeline_x/pipeline_x_fragment_context.cpp:
##########
@@ -250,7 +248,7 @@ Status PipelineXFragmentContext::prepare(const
doris::TPipelineFragmentParams& r
return Status::OK();
}
-Status PipelineXFragmentContext::_plan_local_shuffle(
+Status PipelineXFragmentContext::_plan_local_exchange(
Review Comment:
warning: method '_plan_local_exchange' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status PipelineXFragmentContext::_plan_local_exchange(
```
##########
be/src/pipeline/pipeline_x/pipeline_x_fragment_context.cpp:
##########
@@ -266,20 +264,21 @@
}
}
- RETURN_IF_ERROR(_plan_local_shuffle(num_buckets, pip_idx,
_pipelines[pip_idx],
- bucket_seq_to_instance_idx));
+ RETURN_IF_ERROR(_plan_local_exchange(num_buckets, pip_idx,
_pipelines[pip_idx],
+ bucket_seq_to_instance_idx));
}
return Status::OK();
}
-Status PipelineXFragmentContext::_plan_local_shuffle(
+Status PipelineXFragmentContext::_plan_local_exchange(
Review Comment:
warning: method '_plan_local_exchange' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status PipelineXFragmentContext::_plan_local_exchange(
```
##########
be/src/pipeline/pipeline_x/pipeline_x_fragment_context.h:
##########
@@ -154,10 +154,10 @@ class PipelineXFragmentContext : public
PipelineFragmentContext {
const TPipelineFragmentParams& params, const
RowDescriptor& row_desc,
RuntimeState* state, DescriptorTbl& desc_tbl,
PipelineId cur_pipeline_id);
- Status _plan_local_shuffle(int num_buckets,
- const std::map<int, int>&
bucket_seq_to_instance_idx);
- Status _plan_local_shuffle(int num_buckets, int pip_idx, PipelinePtr pip,
- const std::map<int, int>&
bucket_seq_to_instance_idx);
+ Status _plan_local_exchange(int num_buckets,
+ const std::map<int, int>&
bucket_seq_to_instance_idx);
Review Comment:
warning: parameter 2 is const-qualified in the function declaration;
const-qualification of parameters only has an effect in function definitions
[readability-avoid-const-params-in-decls]
```suggestion
std::map<int, int>&
bucket_seq_to_instance_idx);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
