wangbo commented on code in PR #27969: URL: https://github.com/apache/doris/pull/27969#discussion_r1416599575
########## fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/QueueToken.java: ########## @@ -0,0 +1,131 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.resource.workloadgroup; + +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicLong; +import java.util.concurrent.locks.Condition; +import java.util.concurrent.locks.ReentrantLock; + +// used to mark QueryQueue offer result +// if offer failed, then need to cancel query +// and return failed reason to user client +public class QueueToken { + private static final Logger LOG = LogManager.getLogger(QueueToken.class); + + enum TokenState { + ENQUEUE_SUCCESS, + READY_TO_RUN + } + + static AtomicLong tokenIdGenerator = new AtomicLong(0); + + private long tokenId = 0; + + private TokenState tokenState; + + private long waitTimeout = 0; + + private String offerResultDetail; + + private boolean isTimeout = false; + + private final ReentrantLock tokenLock = new ReentrantLock(); + private final Condition tokenCond = tokenLock.newCondition(); + + public QueueToken(TokenState tokenState, long waitTimeout, + String offerResultDetail) { + this.tokenId = tokenIdGenerator.addAndGet(1); + this.tokenState = tokenState; + this.waitTimeout = waitTimeout; + this.offerResultDetail = offerResultDetail; + } + + public boolean waitSignal() throws InterruptedException { + this.tokenLock.lock(); + try { + if (tokenState == TokenState.READY_TO_RUN) { + return true; + } + tokenCond.await(waitTimeout, TimeUnit.MILLISECONDS); + // If wait timeout and is steal not ready to run, then return false + if (tokenState != TokenState.READY_TO_RUN) { + LOG.warn("wait in queue timeout, timeout = {}", waitTimeout); + isTimeout = true; + return false; + } else { + return true; + } + } catch (Throwable t) { + LOG.warn("meet execption when wait for signal", t); + // If any exception happens, set isTimeout to true and return false + // Then the caller will call returnToken to queue normally. + offerResultDetail = "meet exeption when wait for signal"; + isTimeout = true; + return false; + }finally { + this.tokenLock.unlock(); + } + } + + public boolean signal() { + this.tokenLock.lock(); + try { + // If current token is not ENQUEUE_SUCCESS, then it maybe has error + // not run it any more. + if (this.tokenState != TokenState.ENQUEUE_SUCCESS || isTimeout) { + return false; + } + this.tokenState = TokenState.READY_TO_RUN; + tokenCond.signal(); Review Comment: ```suggestion tokenCond.signal(); this.tokenState = TokenState.READY_TO_RUN; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
