github-actions[bot] commented on code in PR #28029:
URL: https://github.com/apache/doris/pull/28029#discussion_r1415576824
##########
be/src/runtime/load_stream.cpp:
##########
@@ -241,8 +241,11 @@ Status IndexStream::close(const std::vector<PTabletID>&
tablets_to_commit,
return Status::OK();
}
+// TODO: Profile is temporary disabled, because:
+// 1. It's not being processed by the upstream for now
+// 2. There are some problems in _profile->to_thrift()
LoadStream::LoadStream(PUniqueId load_id, LoadStreamMgr* load_stream_mgr, bool
enable_profile)
- : _load_id(load_id), _enable_profile(enable_profile),
_load_stream_mgr(load_stream_mgr) {
+ : _load_id(load_id), _enable_profile(false),
_load_stream_mgr(load_stream_mgr) {
Review Comment:
warning: member initializer for '_enable_profile' is redundant
[modernize-use-default-member-init]
```suggestion
: _load_id(load_id), , _load_stream_mgr(load_stream_mgr) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
